Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compat CUP Terrains - Add sitting compatibility #10645

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Compat CUP Terrains - Add sitting compatibility #10645

merged 7 commits into from
Jan 13, 2025
+192 −60

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title
  • Requires Sitting - Various improvements #10644 to function.
  • Moved the refuelling part of the compat to its separate subaddon.
  • I haven't tested with CUP terrains, but Zeus placed objects work without issue. Do I need to add EGVAR(interaction,replaceTerrainObject) = 1; to have it work with baked-in terrain objects?

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Jan 12, 2025
@LinkIsGrim LinkIsGrim added this to the 3.18.3 milestone Jan 13, 2025
@LinkIsGrim
Copy link
Contributor

Do I need to add EGVAR(interaction,replaceTerrainObject) = 1; to have it work with baked-in terrain objects?

Yes IIRC

@johnb432
Copy link
Contributor Author

Yes IIRC

Should I add it to all objects I've added compatibility for?

@LinkIsGrim
Copy link
Contributor

Up to you. I don't much care for not being able to sit on terrain objects but I can see that bothering people.

@johnb432
Copy link
Contributor Author

Up to you. I don't much care for not being able to sit on terrain objects but I can see that bothering people.

I'm a little worried about the potential performance impact that swapping in objects could have, but I don't know, as I have no idea how many terrain objects would be replaced.

@LinkIsGrim
Copy link
Contributor

They're only replaced if a player tries to interact with them, right? Should be fine.

@LinkIsGrim LinkIsGrim changed the title CUP Terrains Compat - Add sitting compatibility Compat CUP Terrains - Add sitting compatibility Jan 13, 2025
@johnb432
Copy link
Contributor Author

They're only replaced if a player tries to interact with them, right? Should be fine.

It seems so, will update accordingly then.

@LinkIsGrim LinkIsGrim modified the milestones: 3.19.1, 3.19.0 Jan 13, 2025
@johnb432
Copy link
Contributor Author

@LinkIsGrim Done.

@LinkIsGrim LinkIsGrim merged commit 4a65e32 into master Jan 13, 2025
3 checks passed
@johnb432 johnb432 deleted the compat-cup-terrain-sitting branch January 13, 2025 21:42
PlayerBotPro pushed a commit to PlayerBotPro/ACE3 that referenced this pull request Jan 14, 2025
@johnb432 @LinkIsGrim @PlayerBotPro
Compat CUP Terrains - Add sitting compatibility (acemod#10645)
9eb3e11 
Co-authored-by: Grim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@johnb432 @LinkIsGrim @PabstMirror